JPPF Issue Tracker
star_faded.png
Please log in to bookmark issues
bug_report_small.png
CLOSED  Bug report JPPF-56  -  Bad initialization of management broadcast information
Posted Aug 30, 2012 - updated Aug 31, 2012
icon_info.png This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Bug report
  • Status
     
    Closed
  • Assigned to
     lolo4j
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
     lolo4j
  • Owned by
    Not owned by anyone
  • Estimated time
    Not estimated
  • Category
    Server
  • Resolution
    RESOLVED
  • Priority
    Normal
  • Reproducability
    Always
  • Severity
    Not determined
  • Targetted for
    icon_milestones.png JPPF 3.1.2
Issue description
From this forum discussion.

The method org.jppf.server.DriverInitializer.getConnectionInformation() has the following:
if (config.getBoolean("jppf.management.enabled", true))
{
  connectionInfo.managementPort = config.getInt("jppf.management.port", 11198);
  connectionInfo.sslManagementPort = config.getInt("jppf.management.port", 11198);
}
We can see that the plain and secure management ports that will be broadcast by the server will have the same value, which is incorrect

Instead we should have:
if (config.getBoolean("jppf.management.enabled", true))
  connectionInfo.managementPort = config.getInt("jppf.management.port", 11198);
if (config.getBoolean("jppf.management.ssl.enabled", false))
  connectionInfo.sslManagementPort = config.getInt("jppf.management.ssl.port", 11193);
Steps to reproduce this issue
This is an identified proble in the code.

#2
Comment posted by
 lolo4j
Aug 30, 08:03
In fact I just realized that connectionInfo.managementPort and connectionInfo.sslManagementPort are later overriden in method DriverInitializer.createJMXServer():
if (!ssl) info.managementPort = server.getManagementPort();
else info.sslManagementPort = server.getManagementPort();
So I believe we should remove the initialization of these attributes from getConnectionInformation() alltogether, since the management port may not be the one configured in the configuration file: the driver checks if the configured port is already bound, in which case it will try different ports (by incrementing up to 65535 with rollover to 1024), until it finds one that works.
#4
Comment posted by
 lolo4j
Aug 31, 02:42
Fixed. Changes committed to SVN:

The issue was updated with the following change(s):
  • This issue has been closed
  • The status has been updated, from New to Closed.
  • This issue's progression has been updated to 100 percent completed.
  • The resolution has been updated, from Not determined to RESOLVED.
  • Information about the user working on this issue has been changed, from lolo4j to Not being worked on.