JPPF Issue Tracker
star_faded.png
Please log in to bookmark issues
feature_request_small.png
CLOSED  Feature request JPPF-260  -  Deprecate usage of TaskResultListener in exposed APIs
Posted May 11, 2014 - updated May 29, 2014
action_vote_minus_faded.png
0
Votes
action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Feature request
  • Status
     
    Closed
  • Assigned to
     lolo4j
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
     lolo4j
  • Owned by
    Not owned by anyone
  • Estimated time
    Not estimated
  • Category
    Client
  • Resolution
    RESOLVED
  • Priority
    Normal
  • Targetted for
    icon_milestones.png JPPF 4.2
Issue description
We document the TaskResultListener property of a job. However, we also document JobListener which has a more complete, finer grained set of features, and whose jobReturned() notifications are called the same number of times as TaskResultListener.resultsReceived(), thus introducing an unneeded and potentially confusing duplication of the functionality.

Furthermore, a lot of the client code relies on the JPPFResultCollector implementation of TaskResultListener. For instance, the client-side job persistence is only performed in JPPFResultCollector.resultsReceived(). Also the JPPFExecutorService relies heavily on the subclass FutureResultCollector.

We propose to deprecate the usage of the TaskResultListener in the public exposed APIs (essentially the getter and setter in JPPFJob) and make TaskResultListener and its implementations internal APIs. This also implies deprecating the related documentation, and rewriting the code snippets and examples so they use a JobListener instead.

#2
Comment posted by
 lolo4j
May 22, 22:58
Additionally, we need methods in a the JPPFJob class that are the equivalents of JPPFResultCollector's awaitResults() and getAllResults()
#3
Comment posted by
 lolo4j
May 29, 11:09
implemented in trunk revision 3208